fairvotereform / RankIt

https://rankit.vote
1 stars 2 forks source link

As a poll creator, I can export results data to RCVIS #99

Closed ggordn3r closed 4 years ago

ggordn3r commented 4 years ago

Some people in the advisory group really seem to like the visualizations on RCVIS. Rather than recreate them within RankIt, we should enable users to export the results in a format that can be imported into RCVIS: https://www.rcvis.com/upload.html

I think "poll creator" is the right role for this. Shouldn't be limited to admin, but probably too confusing for a typical person voting and sharing.

At the same time this is enabled, we should also remove "/raw", which is our current workaround (and a security liability).

ggordn3r commented 4 years ago

116 enhances this by pushing JSON to RCVIS. It's another open-source project and the developer is willing to assist on his end.

proggeramlug commented 4 years ago

@ggordn3r It sounds like this is already implemented? If so where, what do you mean by "/raw"?

ggordn3r commented 4 years ago

No, it's not implemented. Stephen just built in a way to inspect the raw votes:

Here's an example poll: https://rankit.vote/results/zDvGganVwjdYGafT2mLh/summary

And here's the JSON for it: https://rankit.vote/results/zDvGganVwjdYGafT2mLh/raw

Appending "/raw" will work for any poll. But you just see the raw votes in JSON.

proggeramlug commented 4 years ago

@iambateman did you push this to git? I'm not seeing the raw function in the code. However it's not very useful so don't bother much ;D

@ggordn3r would it not make sense to drop this feature in favor of the JSON? The json doesn't look very complicated to be created ...

ggordn3r commented 4 years ago

Some users have said that they want to be able to download a CSV of results so they can look at them in a spreadsheet, independent of the request for RCVIS. So ideally we should give them both options.

Trey Gordner Founder, Koios (803) 570-2144 Website https://www.koios.co | Twitter https://twitter.com/koioslib | Join our Newsletter https://www.koios.co/join-koios-newsletter/ Helping libraries show up online

On Thu, Apr 30, 2020 at 12:01 PM Ralph Küpper notifications@github.com wrote:

@iambateman https://github.com/iambateman did you push this to git? I'm not seeing the raw function in the code. However it's not very useful so don't bother much ;D

@ggordn3r https://github.com/ggordn3r would it not make sense to drop this feature in favor of the JSON? The json doesn't look very complicated to be created ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iambateman/RankIt/issues/99#issuecomment-621946217, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNMYBHNGAKEVSUAFYQ3RZLRPGOGJANCNFSM4LDEBSTQ .

proggeramlug commented 4 years ago

This is implemented now, check it out!

ggordn3r commented 4 years ago

This is cool! One question--I'm noticing a blank vote in one of the polls I downloaded (see row 7 in the spreadsheet below). Shouldn't that be impossible?

The poll in question: https://rankit.skelpo.com/polls/h2rjTQZMM4PYtsDAbQZv

The Results (direct paste of CSV):

Choice 1 Choice 2 Choice 3 Choice 4 createdAt
Discuss a new topic every week (members suggest ideas) Read a new contemporary Christian book together Follow the Genesis sermon series Study a book of the Bible besides Genesis 1.57E+12
Study a book of the Bible besides Genesis Read a new contemporary Christian book together Follow the Genesis sermon series Discuss a new topic every week (members suggest ideas) 1.57E+12
Discuss a new topic every week (members suggest ideas) Read a new contemporary Christian book together Study a book of the Bible besides Genesis Follow the Genesis sermon series 1.57E+12
Discuss a new topic every week (members suggest ideas) Follow the Genesis sermon series Study a book of the Bible besides Genesis Read a new contemporary Christian book together 1.57E+12
Discuss a new topic every week (members suggest ideas) Study a book of the Bible besides Genesis Follow the Genesis sermon series   1.57E+12
        1.59E+12
Study a book of the Bible besides Genesis Discuss a new topic every week (members suggest ideas) Read a new contemporary Christian book together Follow the Genesis sermon series 1.57E+12
Discuss a new topic every week (members suggest ideas) Read a new contemporary Christian book together Study a book of the Bible besides Genesis Follow the Genesis sermon series 1.57E+12
Study a book of the Bible besides Genesis Discuss a new topic every week (members suggest ideas) Read a new contemporary Christian book together Follow the Genesis sermon series 1.57E+12
Read a new contemporary Christian book together       1.57E+12
Discuss a new topic every week (members suggest ideas) Follow the Genesis sermon series Study a book of the Bible besides Genesis Read a new contemporary Christian book together 1.57E+12
proggeramlug commented 4 years ago

@ggordn3r Probably an error when testing or working on it. The entry is actually empty. Do we want to filter such votes? I have no clue how many there are in the system.

BTW: I happened: 04/24/2020 @ 9:29pm

ggordn3r commented 4 years ago

I'm going to mark this as closed on the assumption that it's a legacy issue, but if beta testers report empty entries, I'll open it again.

ggordn3r commented 4 years ago

Actually, one last small thing: can you disable the "Download CSV" button when Voters = 0?

proggeramlug commented 4 years ago

Done!

ggordn3r commented 4 years ago

Thanks! One more: can you use fa-table for the Download CSV icon instead of fa-pencil? https://fontawesome.com/v4.7.0/icon/table

proggeramlug commented 4 years ago

Done