fairwaves / UHD-Fairwaves

Fairwaves version of the UHD drivers, tweaked to support Fairwaves UmTRX.
http://umtrx.org
24 stars 21 forks source link

umtrx can not build against recent uhd release - no msg.hpp #21

Closed guruofquality closed 4 years ago

guruofquality commented 6 years ago

Some of the logging api changed, and <uhd/utils/msg.hpp> is no longer present. I had to fix this with soapy uhd, the logging usage looks like this now: https://github.com/pothosware/SoapyUHD/blob/master/UHDSoapyDevice.cpp#L837

clebig commented 6 years ago

Hi ! Is there a workaround that could help in building the current sources in master ?

Thank you.

chemeris commented 6 years ago

@clebig Not yet, unfortunately. Someone has to write a patch to replace all UHD_MSG with UHD_LOG_*. If you write one, please send us a Pull Request here.

clebig commented 6 years ago

Hi @chemeris , Thanks for your reply. Which version of UHD should I use to compile the UHD-Fairwaves driver ? Is UHD-3.9.LTS a good candidate ? I will look at the code if I find the time next week.

clebig commented 5 years ago

Actually, it's not only msg.hpp which is missing. Some other dependencies have been deprecated. As far as I can tell, atomic.hpp has changed, "reusable_barrier" type which was part of atomic.hpp doesn't exist anymore. It must be brought from somewhere else. Ettus has implemented barrier.h for instance but in it current state, it includes and depends on ettus' specific headers (ettus/api.h). I'm expecting more things to be changed before being able to compile.

clebig commented 5 years ago

Is there any plan to update UHD-Fairwaves tree in the future to be usable with recent versions of UHD ?

ibra1212 commented 4 years ago

I'm working with the UmTRX 2.1 with openBTS recently. i am trying to install the UHD module of faiwaves but i have this error:

/home/openbts/UHD-Fairwaves-1.0.18/host/cores/super_recv_packet_handler.hpp:27:32: fatal error: uhd / utils / atomic.hpp: No files or folders of this type

Can you help me please?

clebig commented 4 years ago

Build and install the branch UHD-3.9.LTS of their github repo

github.com/EttusResearch/uhd.git

Le jeu. 19 sept. 2019 à 15:02, ibra1212 notifications@github.com a écrit :

I'm working with the UmTRX 2.1 with openBTS recently. i am trying to install the UHD module of faiwaves but i have this error:

/home/openbts/UHD-Fairwaves-1.0.18/host/cores/super_recv_packet_handler.hpp:27:32: fatal error: uhd / utils / atomic.hpp: No files or folders of this type

Can you help me please?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fairwaves/UHD-Fairwaves/issues/21?email_source=notifications&email_token=AECZPTMHI3YDFV3B4PI7E5TQKNZ6BA5CNFSM4EUYFQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7DMK3Y#issuecomment-533120367, or mute the thread https://github.com/notifications/unsubscribe-auth/AECZPTMO4KUODJ7NIW76A6TQKNZ6BANCNFSM4EUYFQMA .

ibra1212 commented 4 years ago

Hi clebig, thanks for the quick reply I tested with UHD-3.9.LTS with this link github.com/EttusResearch/uhd.git always using the UHD-Fairwaves module, but the same error message appears.

clebig commented 4 years ago

First, you need to uninstall any previous uhd installation. Then compile and build UHD-3.9.LTS. Once you have cloned the repo, don't forget to "git checkout UHD-3.9.LTS" Before building it.

Le sam. 21 sept. 2019 à 13:13, ibra1212 notifications@github.com a écrit :

Hi clebig, thanks for the quick reply I tested with UHD-3.9.LTS with this link github.com/EttusResearch/uhd.git always using the UHD-Fairwaves module, but the same error message appears.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fairwaves/UHD-Fairwaves/issues/21?email_source=notifications&email_token=AECZPTPAM3N3HNMRJ2YMT73QKX6U3A5CNFSM4EUYFQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IPXCY#issuecomment-533789579, or mute the thread https://github.com/notifications/unsubscribe-auth/AECZPTLEEK5II3C7KVTOHRLQKX6U3ANCNFSM4EUYFQMA .

ibra1212 commented 4 years ago

I just followed your advice, I made the make but there were errors concerning the compiler -std = c ++ 11 that I could solve. the make works wonderfully now. A big thank you for your valuable help.

ibra1212 commented 4 years ago

@clebig Not yet, unfortunately. Someone has to write a patch to replace all UHD_MSG with UHD_LOG_*. If you write one, please send us a Pull Request here.

how can we do it ?

clebig commented 4 years ago

Something tells me that something good will happen quite soon regarding this issue...

In the meantime, you can still compile this code with UHD-3.9.LTS.

Le jeu. 10 oct. 2019 à 17:50, ibra1212 notifications@github.com a écrit :

@clebig https://github.com/clebig Not yet, unfortunately. Someone has to write a patch to replace all UHD_MSG with UHDLOG*. If you write one, please send us a Pull Request here.

how can we do it ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fairwaves/UHD-Fairwaves/issues/21?email_source=notifications&email_token=AECZPTIYTYX4W5V26VS3BUDQN5FMJA5CNFSM4EUYFQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA424DI#issuecomment-540651021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECZPTJWQAKN4X2D2C6UNS3QN5FMJANCNFSM4EUYFQMA .

chemeris commented 4 years ago

I've just merged several fixes and it should now compile both for old and new UHD versions.

Specifically, I've tested with UHD 3.10 (Ubuntu 18.04 default) and UHD 3.14 (the latest from Ettus Research PPA).

I'm closing this issue - if you have any issues with the new UHD versions - please reopen.

clebig commented 4 years ago

:-), thanks a lot Alexander ! I'll test it on Monday. Which version of GCC and libboost have you used ?

Clement

chemeris commented 4 years ago

Everything is from latest Ubuntu 18.04 repo except UHD: gcc 7.4.0 Boost 1.65.1

clebig commented 4 years ago

It compiles correctly now on x86_64 on debian 10 with the following tools : UHD 3.14 cmake 3.13 libboost 1.67 gcc 8.3 / libstdc++ 8.3

It also compiles on Raspbian Buster with UHD 3.14 (some tweaking needed to compile UHD from ettus' repo) cmake 3.13 libboost 1.67 gcc 8.3 / libstdc++ 8.3

umtrx_test_chains runs on both.

bbaranoff commented 2 years ago

It compiles correctly now on x86_64 on debian 10 with the following tools : UHD 3.14 cmake 3.13 libboost 1.67 gcc 8.3 / libstdc++ 8.3

It also compiles on Raspbian Buster with UHD 3.14 (some tweaking needed to compile UHD from ettus' repo) cmake 3.13 libboost 1.67 gcc 8.3 / libstdc++ 8.3

umtrx_test_chains runs on both.

Against 3.14

nirvana@hp:~/uhd$ sudo locate msg.hpp
/home/nirvana/uhd/host/lib/deps/rpclib/include/rpc/msgpack/preprocessor/assert_msg.hpp
/home/nirvana/uhd/host/lib/include/uhdlib/rfnoc/async_msg.hpp
/usr/include/boost/preprocessor/assert_msg.hpp
/usr/include/boost/spirit/home/support/assert_msg.hpp

You meaned 3.10 ???