fairy-stockfish / fairy-stockfish.wasm

WebAssembly port of the chess variant engine Fairy-Stockfish with NNUE support
https://fairy-stockfish-nnue-wasm.vercel.app/
GNU General Public License v3.0
22 stars 9 forks source link

Synchronize main project (Closing Milestone v14.0.2) #17

Closed yjf2002ghty closed 4 months ago

yjf2002ghty commented 5 months ago

This pull request merges recent changes like https://github.com/fairy-stockfish/Fairy-Stockfish/pull/780 and https://github.com/fairy-stockfish/Fairy-Stockfish/pull/792 . If there are any changes, you can apply the changes based on this pull request which can save time.

Note that I removed the "Publish to NPM" step in the CI as I'm not the publisher. Adding back it is needed before or after merging.

      - name: Publish to NPM
        if: startsWith(github.ref, 'refs/tags/')
        working-directory: src/emscripten/public
        run: |
          npm config set //registry.npmjs.org/:_authToken ${NPM_TOKEN}
          npm publish
        env:
          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

I've tested it in the CI and it passed. image

ianfab commented 4 months ago

Thanks. However, for the dependent projects like wasm and NNUE data generator I prefer to directly merge from the upstream project to keep the history clean, otherwise this might create future merge conflicts.

With respect to the CI, my assumption is that there would be no need to remove the publish step, since this is only triggered by tag creation, so nobody without the required write access can do it by accident.