search

fairyglade / ly

display manager with console UI
Do What The F*ck You Want To Public License
5.52k stars 307 forks source link

Ly overwrites pam file on update #480

Open Zaph-x opened 1 year ago

Zaph-x commented 1 year ago

When upgrading ly on Arch linux, through yay, ly replaces the settings specified in its pam file. For me, on my ThinkPad T560, it means, that after I enter my password, ly also requires me to use fingerprint to authenticate. There is no additional prompt for me to know I have to swipe my finger, and in docked mode, I have no visual cues for this. My temporary fix to this problem has been to manually edit the pam file, after each upgrade, however this does not seem like a good solution to this problem. In actuallity, the pam file should only be created if it does not exist, and should not be modified when upgrading ly.

AnErrupTion commented 6 months ago

@Zaph-x What if the default PAM file is subject to updates? This would be the case with #496 for example. Sure, we could add an option, but then you, the end user, wouldn't be able to control that during an update (as ly is most likely going to be installed through a package manager).

moabeat-berlin commented 4 months ago

For me this sounds more like a packaging issue with Arch Linux. According to the Arch Wiki, this should not happen like @Zaph-x describes it. Either this is the case 'original = X, current = Y, new = X', when the file wasn't changed in the ly package or it should create a .pacnew file in the case of 'original = X, current = Y, new = Z', leaving it to user to incorporate the changes coming in with the update.