fairyglade / ly

display manager with console UI
Do What The F*ck You Want To Public License
5.33k stars 306 forks source link

Confusing default config: Everything commented out, some lines do, some don't match the defaults #574

Closed Shallrath closed 4 months ago

Shallrath commented 8 months ago

I think the default /etc/ly/config.ini should contain the actual default configuration values that are not commented out but actually enabled. The explanatory comments are great though.

I stumbled upon this when setting up Ly for the first time and having problems with PAM because the service name was not set to "ly" as mentioned in the config's comments. I assumed that this was the default behavior because the line "service_name = ly" was in /etc/ly/config.ini but commented out. Turned out the default is different in this case. In most other cases, the commented-out lines match what is the default so I assumed I only need to enable the lines that I deliberately want to change.

Having an actually enabled config file that has all the default settings in place and not commented out with ambiguous default behavior would avoid this kind of confusion.