Do not force LANG env var on login

fairyglade / ly

display manager with console UI

Do What The F*ck You Want To Public License

5.33k stars 306 forks source link

Do not force LANG env var on login #581

Closed xelantro closed 4 months ago

xelantro commented 7 months ago

Regarding issue #278 Is there any reason we have to set the LANG env var? At least on arch systems this causes the custom LC_* configs form /etc/locale.conf to not be applied (/etc/profile.d/locale.sh if [ -z "$LANG" ]; then)

AnErrupTion commented 4 months ago

Closing since it got fixed in the Zig rewrite. To compensate, I'll tag your account when 1.0.0 is gong to be released for making the original patch.

xelantro commented 4 months ago

@AnErrupTion don't worry about it, I just changed a single line :) I'm just happy when it's finally fixed :heart:

AnErrupTion commented 4 months ago

@AnErrupTion don't worry about it, I just changed a single line :) I'm just happy when it's finally fixed ❤️

I'd feel bad not to credit you even if it's just a single line change! You have no idea how many of those are actually useful 👀