fairyglade / ly

display manager with console UI
Do What The F*ck You Want To Public License
5.35k stars 307 forks source link

Matrix animation bug #624

Closed Hunman closed 1 month ago

Hunman commented 3 months ago

After recently updating, a bunch of the letters start falling at the same time

OS: Arch Linux Installed version: ly-git 0.6.0.r10.g3d8d8d6-1 (= commit 3d8d8d6) from the aur (application reports Ly version 1.0.0-dev) Previous version: 0.6.0.r4.g4ee2b3e (= commit 4ee2b3e)

image

The commits between: image

AnErrupTion commented 3 months ago

@Hunman I believe this issue is now fixed in v1.0.0. Can you check, please?

Hunman commented 3 months ago

Updated it through the aur and now the version seems to be Ly version 1.1.0-dev.4+dc8d143, however the bug still persists above a certain window size

image

In a 85 character wide window, Matrix seems to start correctly image

But 86 characters and above the bug occurs still (only at the start) image

yannfill commented 2 months ago

I confirm that the bug is still present in package version 1.0.0.-1 from extra on Arch.

AnErrupTion commented 2 months ago

@Hunman @yannfill Can you now check if it's fixed with master please? I'm unable to reproduce it exactly like how you see it, but hopefully the commit fixes it.

Hunman commented 2 months ago

It seems to be working now

yannfill commented 2 months ago

I don't know if the commit was merged in 1.0.1 release but the bug is still there in the Arch package.

AnErrupTion commented 2 months ago

I don't know if the commit was merged in 1.0.1 release but the bug is still there in the Arch package.

Ah yeah it wasn't, it's merged for v1.0.2, but that's not released yet.

AnErrupTion commented 2 months ago

@yannfill Ly v1.0.2 hit the repos, can you confirm the bug is fixed on your side please?

yannfill commented 1 month ago

Yes, the bug is fixed now on Arch.

AnErrupTion commented 1 month ago

Great! Thanks for confirming!