search

fairyglade / ly

display manager with console UI
Do What The F*ck You Want To Public License
5.47k stars 305 forks source link

feat: support zig `0.13.0` and setting default TTY at build time #632

Closed jinzhongjia closed 4 months ago

jinzhongjia commented 4 months ago

Feature:

It has not yet been tested whether it can be compiled with 12

jinzhongjia commented 4 months ago

What do you think of trying to add github action to support CI? @AnErrupTion

AnErrupTion commented 4 months ago

It has not yet been tested whether it can be compiled with 12

It's unlikely you'll be able to because of the ChildProcess change. We could always try to add some compile-time condition, but I feel like that's unnecessary.

What do you think of trying to add github action to support CI?

I don't personally think that's useful given the scope of Ly.

jinzhongjia commented 4 months ago

Good CI can help ensure certain build compatibility But if you only maintain compatibility with the latest release zig, there is no need.

jinzhongjia commented 4 months ago

After all, sometimes the person who initiated the PR may not do a complete version compatibility test.

jinzhongjia commented 4 months ago

The current problem is caused by clap in latest version being incompatible with version 12. Need to open pr to clap

AnErrupTion commented 4 months ago

The current problem is caused by clap in latest version being incompatible with version 12. Need to open pr to clap

I don't think clap maintains backwards compatibility with older versions of Zig either, you'll have to check with them on that.

jinzhongjia commented 4 months ago

acorrding to this issue,https://github.com/Hejsil/zig-clap/issues/128

It seems that not to be backward compatible

jinzhongjia commented 4 months ago

ok , clap has agreed to maintain backward compatibility with current 12

jinzhongjia commented 4 months ago

We just need to wait for clap to merge pr.

jinzhongjia commented 4 months ago

Now clap's pr has been merged, zigini still has a little problem, but I have opened a PR

jinzhongjia commented 4 months ago

https://github.com/Kawaii-Ash/zigini/pull/1

jinzhongjia commented 4 months ago

We currently only need to wait for the PR merge to be completed. My local test of 0.12 and 0.13 has passed.

jinzhongjia commented 4 months ago

this issue: https://github.com/fairyglade/ly/issues/225

Added option for build: default_tty @AnErrupTion please review my commit again. I'm not sure if it's correct.

jinzhongjia commented 4 months ago

now, everything should be ok

AnErrupTion commented 4 months ago

Thanks for your contribution!