Efiamotu-1
commented
9 months ago Hi @team,
Good job so far! 👏. Your Code is Awesome! 💪
There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃
Don't Worry 🙏
It's ok to have bugs in your code 🐛. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality 💯 and help you get a better 💼.
I am going to guide you on how to fix them down below. 🤓
Highlights :dart:
- ✔️ No linter Errors
- ✔️ Descriptive README
- ✔️ Descriptive PR title and description
- The code is top-notch! 💯 and has a huge potential.
Required Changes ♻️
- [ ] From the image below, you have repeated the same task as shown by the red arrow, please kindly look into this and correct it accordingly :+1: :sparkles:
- [ ] Because of the abovce error, student A is now having to do more tasks than required, so kindly make this correction so that the tasks would be shared equally :+1: :sparkles:
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Important Notes 📝
- Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
- Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Note: Please, don't Merge This Pull Request yet. Only Merge when it is Approved ✅.
Thank you for your time 🙏 and call me if you need help or clarification ☎️
- This is My GitHub:
- This is My Twitter:
- This is My linkedIn.
- This is My Slack:
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
thecodechaser
RoR group project: Food Recipe app
We are three group members.
This is a group capstone project where we create a Food Recipe App that will help you to keep a record of your recipes. Everything will be based on the UML class diagram and the wireframes provides by Microverse . And for this purpose we created the Kanban board setup. Please check by clicking the following link : Project Link : https://github.com/faisalakb/food-recipe-group/projects/1
Members of the group: 🧑🤝🧑 @axcell-0 Student -A @faisalakb Student -B @luigirazum Student- C