Chrome OS isn't detected

faisalman / ua-parser-js

"Unmask Your Traffic" - UAParser.js: The Essential Web Development Tool for User-Agent Detection

https://uaparser.dev/

GNU Affero General Public License v3.0

9.29k stars 1.2k forks source link

Chrome OS isn't detected #601

Closed XiupengMa closed 1 year ago

XiupengMa commented 2 years ago

UA: Mozilla/5.0 (X11; CrOS x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.0.0 Safari/537.36

rikbrown commented 2 years ago

Another example: Mozilla/5.0 (X11; CrOS x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.0.0 Safari/537.36

I don't think the current CrOS regex is correct - seems to expect some version info after the arch type. If I change that string to CrOS x86_64 1.1 it now detects it as Chromium OS (which is the wrong name too per https://github.com/faisalman/ua-parser-js/issues/517).

uphunyal1 commented 2 years ago

@rikbrown @XiupengMa I could not find any examples of Chrome UA string for Chrome OS with no version info. How did you get it in this format? Are you using a regular Chrome browser or some other browser based on Chromium?

XiupengMa commented 2 years ago

@uphunyal1 we just go these UA strings from our real clients. we aren't quite sure about their settings.

everythinginjs commented 1 year ago