HONOR needs to be separated from HUAWEI

[pinganlong]

Describe the bug A clear and concise description of what the bug is.

there is a bug in the open-source project you provided on github (https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L504), the code is as follows.

// Huawei /\b((?:ag[rs][23]?|bah2?|sht?|btv)-a?[lw]\d{2})\b(?!.+d\/s)/i ], [MODEL, [VENDOR, HUAWEI], [TYPE, TABLET]], [ /(?:huawei|honor)([-\w ]+)[;)]/i, /\b(nexus 6p|\w{2,4}e?-[atu]?[ln][\dx][012359c][adn]?)\b(?!.+d\/s)/i ], [MODEL, [VENDOR, HUAWEI], [TYPE, MOBILE]], [

Honor has been re-established as an independent company who got no relation with Huawei. Here are a few reports from 2021 for your ref. https://www.huawei.com/en/news/2020/11/huawei-honor-statement https://www.reuters.com/article/uk-huawei-technologies-m-a-digital-china-idUKKBN27W30E

Expected behavior Honor needs to be separated from Huawei. It is an independent brand, just like other brands // Huawei // Vivo // Realme

[Julias0]

I can take this up. Can you assign this to me?

[Julias0]

Let me know if any changes are required in the PR!

[pinganlong]

When can this problem be fixed? Thanks

On Tue, 24 Sept 2024, 14:00 Aiyush, @.***> wrote:

Let me know if any changes are required in the PR!

— Reply to this email directly, view it on GitHub https://github.com/faisalman/ua-parser-js/issues/704#issuecomment-2370261366, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFRIXQORXYJOZU2VBN6TIADZYD5ZFAVCNFSM6AAAAABCGN33ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQGI3DCMZWGY . You are receiving this because you authored the thread.Message ID: @.***>

[faisalman]

@Julias0 I've made a change request in the PR before I can merge.

@pinganlong Do you perhaps have any data regarding HONOR user agents that we can use for testing?

[Julias0]

I have added the fix in the PR and re-requested a review

[faisalman]

Merged