faisalman / ua-parser-js

UAParser.js - The Essential Tool for User-Agent Detection in JavaScript & Web Development.
https://uaparser.dev/
GNU Affero General Public License v3.0
8.85k stars 1.18k forks source link

HONOR needs to be separated from HUAWEI #704

Open pinganlong opened 5 months ago

pinganlong commented 5 months ago

Describe the bug A clear and concise description of what the bug is.

there is a bug in the open-source project you provided on github (https://github.com/faisalman/ua-parser-js/blob/master/src/main/ua-parser.js#L504), the code is as follows.

// Huawei /\b((?:ag[rs][23]?|bah2?|sht?|btv)-a?[lw]\d{2})\b(?!.+d\/s)/i ], [MODEL, [VENDOR, HUAWEI], [TYPE, TABLET]], [ /(?:huawei|honor)([-\w ]+)[;)]/i, /\b(nexus 6p|\w{2,4}e?-[atu]?[ln][\dx][012359c][adn]?)\b(?!.+d\/s)/i ], [MODEL, [VENDOR, HUAWEI], [TYPE, MOBILE]], [

Honor has been re-established as an independent company who got no relation with Huawei. Here are a few reports from 2021 for your ref. https://www.huawei.com/en/news/2020/11/huawei-honor-statement https://www.reuters.com/article/uk-huawei-technologies-m-a-digital-china-idUKKBN27W30E

Expected behavior Honor needs to be separated from Huawei. It is an independent brand, just like other brands // Huawei // Vivo // Realme