faisalman / ua-parser-js

"Unmask Your Traffic" - UAParser.js: The Essential Web Development Tool for User-Agent Detection
https://uaparser.dev/
GNU Affero General Public License v3.0
9.28k stars 1.19k forks source link

feat: Update and expand Chromecast device families #724

Closed joeyparrish closed 3 months ago

joeyparrish commented 6 months ago

Prerequisites

Type of Change

Feature

Description

Update and expand Chromecast device families. This adds support to differentiate between types of Chromecast devices and operating systems, and fixes erroneous classification of Android-based Chromecasts.

Test

Extracted several current useragent strings from various device types in a lab, then added them to the automated tests in us-parser-js. These tests are passing.

Impact

No breaking changes AFAICT.

Other Info

I'm a current member of the Chromecast team at Google, as well as the TL for the open source Shaka Player. We test our video player on many, many devices in a lab using Karma, which uses ua-parser-js to match test results to each device. We need these changes to differentiate between the Chromecast devices in our lab.

joeyparrish commented 3 months ago

Any reason we can't merge this?

joeyparrish commented 3 months ago

Thank you!