faissaloo / SponSkrub

Strip advertisements from downloaded YouTube videos
GNU General Public License v3.0
178 stars 7 forks source link

youtube-dl wrapper breaks when using absolute paths #19

Closed msglm closed 3 years ago

msglm commented 3 years ago

when working with absolute paths (and tools that require them like tsp), the tool will break due to an appending of skrubbed- to the begining of the URI. This causes issues by making the URI for mv or ffmpeg to be skrubbed-/home/user/.... The reason for this is that the wrapper relies on youtube-dl's exec command and appending directly to the end of the file. A fix could be appending skrubbed to the middle of the file (i.e test-skrubbed.mp4 from test.mp4). The current nature of how this tool is set up makes it impossible to use with non-relative paths or tools that reqire them without tons of hacking.

msglm commented 3 years ago

duplicate of #18