search

faissaloo / SponSkrub

Strip advertisements from downloaded YouTube videos
GNU General Public License v3.0
177 stars 7 forks source link

Added -- flag #9

Closed pukkandan closed 3 years ago

pukkandan commented 3 years ago

Closes #8

faissaloo commented 3 years ago

Code looks good so far, but ydl also needs a way to deal with this. I can't specify ydl -dl-args "--" -- -0PyDhv6jlA for example because the dl args aren't passed until the end of the youtube-dl command, we should probably be passing them before.

pukkandan commented 3 years ago

Is this enough?

Also, why was there a -f 18 in that command?

faissaloo commented 3 years ago

The -f 18 is a holdover from earlier versions of ydl where it was mostly just an alias to make it easy to download memes for redistribution since it kept the size reasonable without making it unwatchable. I'll probably just turn that into a local alias for myself going forward instead of having it in the code for this.
I'll give the code a proper look this afternoon.