search

faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)
279 stars 111 forks source link

Added (and tested) support for building 32 + 64 bit macOS universal. #31

Closed mbendiksen closed 6 years ago

mbendiksen commented 6 years ago

Added (and tested) support for building 32 + 64 bit macOS universal.

faithfracture commented 6 years ago

Looks good. Please update the changelog.

Also, it would probably helpful to add some documentation for this, rather than just the comment in the script. How about to the description of the --universal parameter?

--universal
    Create universal FAT binary.
    * macOS target requires --macos-archs "i386 x86_64" parameter as well

or something like that.

You could also just assume that if the user provides the -macos --universal parameters that they do in fact want a FAT binary and just go ahead and set MACOS_ARCHS=("i386 x86_64"). Either way would be fine with me.

mbendiksen commented 6 years ago

I just had it force i386 x86_64 whenever user specifies macOS and universal.

mbendiksen commented 6 years ago

Re-opened pull request. Apparently I don't know how to use github very well. This one should be ready to merge in now.