search

faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)
279 stars 111 forks source link

Fix incorrect ordering of parameters for tar command #33

Closed blloyd75 closed 6 years ago

blloyd75 commented 6 years ago

The script was using tar xfj "filename" However, the syntax for tar is x no parameters f filename. Filename may be either placed immediately after it or may be in the next parameter, with right after the priority. So tar xfj is extract from file j. Instead we want extract bzip2 file "filename", or tar xfj. This is a trivial update changing just that problem.

blloyd75 commented 6 years ago

This was seen when trying to get boost 1.68.0 on the day it was released. Sourceforge did not yet have that version of boost, so curl received a text file instead. Instead of flagging the source file as bogus, it flagged could not open j. When a valid tar.bz2 is supplied, the program acts as desired either way. So the order appears to only matter on a download failure, where the file given is not a valid compressed archive.

faithfracture commented 6 years ago

Good catch. Could you please update the changelog?

faithfracture commented 6 years ago

nvm, I updated it myself.