Fix bugs where archs not copied over properly

faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)

279 stars 111 forks source link

Fix bugs where archs not copied over properly #42

Closed Deadpikle closed 4 years ago

Deadpikle commented 5 years ago

If you defined your own macOS or iOS architectures (or used --universal), then the architectures were not copied correctly. This PR fixes that issue.

Before:

./boost.sh -macos --boost-version 1.70.0 --macos-sdk 10.14 --min-macos-version 10.10  --universal --boost-libs "chrono date_time filesystem system timer"

resulted in a MACOS_ARCHS=i386.

After the fix, MACOS_ARCHS has both i386 and x86_64.

faithfracture commented 5 years ago

Looks like Bintray only has versions from 1.63 & up. It's probably a good idea to check the version & adjust the download URL accordingly.

Deadpikle commented 5 years ago

Uh, I think you meant to post that on #43. No biggie. It's a good point.

faithfracture commented 5 years ago

Oh, yeah, haha, right you are. Doing about 12 different things today :P

Deadpikle commented 5 years ago

No worries 😁

guillaumealgis commented 4 years ago

This was fixed in #47 (reported by shellcheck). I think we can close this.

Thank your @Deadpikle, you were absolutely right!