faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)
279 stars 111 forks source link

Formatting, spinlock, and 32-bit iOS frameworks #65

Open mackworth opened 3 years ago

mackworth commented 3 years ago

Turns out iOS has the same issue as macOS, if you are generating 32-bit versions (i.e. supporting prior to 11.0). armv7 and arm64 need to be lipo'd together (as do the simulator versions). Otherwise, you get a similar error message when trying to build the framework.

In addition, this PR includes:

I included an update to the changelog (embarrassingly called "changeling" in commit msg) that reflect these changes and last PR.

If you want me to separate these commits or make any other changes, happy to do so.

mackworth commented 3 years ago

After I did this pull request, I saw there was one outstanding from @paynerc. His implementation was better, so I've ditched mine and merged his into the other changes I made.

mackworth commented 3 years ago

And after some more testing, realized that the exact same issue applies to Mac Catalyst: if you have both architectures, they need to be lipo'd together before putting into XCFramework.

faithfracture commented 3 years ago

@mackworth Sorry - been focusing on other things recently. Regarding your previous comment, does that mean there needs to be a change to this PR, or is it still ready to go?

mackworth commented 3 years ago

Yes, I've made those changes. I believe we're good to go, although I'd love @paynerc to review.

mackworth commented 3 years ago

just a bump to see if @paynerc approves and if @faithfracture should proceed.