faithoflifedev / easy_onvif_workspace

This package works with a variety of ONVIF compatible devices allowing for IP Cameras and NVRs (network video recorders) to be integrated into Dart and Flutter applications.
33 stars 21 forks source link

Fix axis usage in zoomOut method #64

Closed momshaddinury closed 5 days ago

momshaddinury commented 6 days ago

Description:

This PR fixes the axis usage in the zoomOut method to align with their intended behavior as described in the comments.


Changes Made:

  1. Updated zoomOut to manipulate the negative z-axis (farther).

Updated Code:

  /// A helper method to perform a single [step] of a [relativeMove] on the
  /// negative y axis (farther)
  Future<void> zoomOut(String profileToken, [double step = 0.025]) async {
    loggy.debug('zoomOut');

    await zoom(profileToken, Vector1D(x: -step));
  }

Testing:


Related Issue:

Fixes #63

faithoflifedev commented 5 days ago

Thanks @momshaddinury, this PR helped me find a bug in the cli application I use for some testing. A new package will be released shortly.