search

faizalshap / react-native-otp-verify

React native sms verification without additional permissions
MIT License
252 stars 96 forks source link

added annonation module #15

Closed Raunak-Agrawal closed 4 years ago

faizalshap commented 4 years ago

hi @Raunak-Agrawal Thanks for contributing to this repo. Please add description of what this PR aims to resolve or add. Regards,

Raunak-Agrawal commented 4 years ago

I have changed android to androidx in RNOtpVerifyModule.java file for this line "import android.support.annotation.NonNull". I was using this library in my project and it couldn't resolve because of android. After changing to androidx it got solved. So i raised a PR for the same

Raunak-Agrawal commented 4 years ago

Any updates on this @faizalshap ?

Raunak-Agrawal commented 4 years ago

Thank you faizal :) Raunak

On Wed, Apr 29, 2020 at 7:13 AM Faizal Shap notifications@github.com wrote:

Merged #15 https://github.com/faizalshap/react-native-otp-verify/pull/15 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/faizalshap/react-native-otp-verify/pull/15#event-3282723119, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOQLMVUH5L7EHGIJYTYQ7DRO6A2HANCNFSM4KYHLOWA .

hosseinmd commented 3 years ago

Could you publish this?