faizmalkani / Fabulous

[DEPRECATED]
MIT License
478 stars 117 forks source link

color attribute for FloatingActionButton conflicts with an attribute defined in android.support.v7.appcompat #26

Open bengvr3 opened 9 years ago

bengvr3 commented 9 years ago

I suggest renaming color to colorBackground.

LeebeeDev commented 9 years ago

Just rename the color attribute to whatever else, alse make sure to rename the FloatingActionButton_color in FloatingActionButton class. That was my solution.

bengvr3 commented 9 years ago

That fixes the problem. You might want to consider changing it in the future. On Jan 14, 2015 12:11 PM, "Aimen7" notifications@github.com wrote:

Just rename the color attribute to whatever else, alse make sure to rename the FloatingActionButton_color in FloatingActionButton class. That was my solution.

— Reply to this email directly or view it on GitHub https://github.com/FaizMalkani/FloatingActionButton/issues/26#issuecomment-69951999 .

bytehala commented 9 years ago

Agreed with bvr, every other person using the library shouldn't have to always change it in their own copy. FAB as a library right now doesn't play nice with the compatibility lib.