search

fajarmf / ueberauth_linkedin

LinkedIn OAuth2 Strategy for Überauth.
MIT License
10 stars 42 forks source link

Removed unnecessary Process call #3

Closed TheRickTM closed 7 years ago

TheRickTM commented 8 years ago

Process was causing error on latest Phoenix build

r-gr commented 8 years ago

This is likely caused by the process still being alive with the same name on an unsuccessful request as in #2. Looking at it, spawning and registering a process for checking the CSRF token was a stupid idea for many reasons (my fault) but removing the CSRF protection required by Linkedin is definitely not a solution.

This requires an alternative method for storing the state (token) before the request and comparing it with the callback data. I can't currently think of a way to easily achieve this off the top of my head but I'm sure it's simple enough.

TheRickTM commented 7 years ago

There is another pull request with the correct solutions. Closing this in favor of the cookie method.