fake-name / xA-Scraper

69 stars 8 forks source link

Some main.py msgs suppressed unless xAdebug != 0 #66

Closed God-damnit-all closed 4 years ago

God-damnit-all commented 4 years ago

Launching main.py is so spammy, so I figured I'd have the messages appear by enabling an env variable. Only, I noticed that there already is that functionality for something else - and it disables the scheduler. So I renamed it to xAdebug and that's lvl-2. The assumption is xAdebug equals either 0, 1, 2, doesn't exist (equivalent to 0), or it's something else (equivalent to 1, I believe).

Oh, and the Scheduling messages now uses the scraper name instead of scraperClass; that didn't seem worth a separate commit.

fake-name commented 4 years ago

Please default to the normal output, rather then the other way. E.g. add a silent flag, or similar.

Also, I don't exactly understand what you want this for in general. Is this basically you wanting to run the web stuff without the scheduler? All you need to do that is to just not invoke scheduleJobs(), though the better option would be to just directly invoke runServer() as an alternative path at the beginning of go().

That shouldn't be called "debug" or similar though, it should be web_only or similar. Also, TitleCase in cli stuff is a bad idea in general.

God-damnit-all commented 4 years ago

Actually I did this because I wanted to start using the scheduler now that I feel as though I've collected just about everything I could want, and I found it a bit annoying how many redundant messages there were during the main launch sequence.

I forgot environmental variables are case-sensitive in Linux. Not very used to case-sensitivity in general really.

God-damnit-all commented 4 years ago

meh fuck it