search

fakedata-haskell / fakedata

Haskell Library for producing quality fake data
BSD 3-Clause "New" or "Revised" License
149 stars 22 forks source link

Add Semigroup and Monoid instances for Fake #12

Closed ricksanchez closed 4 years ago

ricksanchez commented 4 years ago

We can alternatively use GeneralizedNewtypeDeriving, it generates the same

ricksanchez commented 4 years ago

Sure. What is the expected version for @since? Sorry for not adding the test, I didn't find tests for functor and others in FakerSpec, so I omitted, I will add anyway.

psibi commented 4 years ago

@ricksanchez Thanks! It would be version 0.6.1 following PVP.

Sorry for not adding the test, I didn't find tests for functor and others in FakerSpec, so I omitted, I will add anyway.

Yeah, sorry about that. Ideally, it's better to have tests for them also. :-)

psibi commented 4 years ago

Thanks!