search

fakemanhk / openwrt-jp-ipoe

Configure OpenWRT to work with Japan NTT IPv6 service
132 stars 14 forks source link

CRLF in map.sh vs LF #14

Closed TimOfAllTrades closed 1 year ago

TimOfAllTrades commented 1 year ago

I don't know if I am getting this right, but when I download the map.sh file, it appears to contain CRLF line breaks. At least on my router, it seems only LF can be used and CRLF line breaks will cause an error. Is it worth mentioning?

Also a footnote for less smart people like me, maybe mention flip the execute bit is chmod 755 (to be the same as the other files I guess).

fakemanhk commented 1 year ago

That's strange, I can take a look on the file later.

But for execute bit issue, I did mention it after the diff content (just not the exact command), probably I should have made it more clear, let me verify with the file and update together.

fakemanhk commented 1 year ago

Does it work if you use this direct link to download?

TimOfAllTrades commented 1 year ago

It was the same, but you know what, it is probably just my own notepad++ acting wierd. Go ahead and disregard this. Thanks for your effort.