fakemanoan / LineageOS-Releases

LineageOS releases for devices.
57 stars 2 forks source link

Double tap to wake not workingin 19.1 #60

Closed darkdragon-001 closed 4 months ago

darkdragon-001 commented 11 months ago

In Android 9 RR this was working fine, so I expect hardware capabilities to exist.

There is a bug that this is not available from the GUI but even setting via adb shell settings put secure double_tap_to_wake 1 and adb shell settings put global double_tap_to_wake 1 didn't work.

fakemanoan commented 11 months ago

The S6 didnt ship with double tap to wake and does not have it as a feature. People added it after the fact with community patches, which I havent put into the kernel.

I will look into adding this at a later date.

darkdragon-001 commented 11 months ago

This would be awesome as this is reducing the number of physical button presses. This in turn increases the hardware lifetime of this phone as physical buttons have a limited lifetime based on the number of presses.

fakemanoan commented 6 months ago

working on adding it as a feature. right now it isnt hooked up to the UI, due to some issues when the screen goes off, but the same stuff you used is implemented in the kernel and can be activated by sysfs

write 1 /sys/class/dt2w/enabled

(latest lineage 20 as of writing this post)

fakemanoan commented 6 months ago

i think i have got it working semi stable now.

expect to see this maybe in the next release if all goes well, which should be relatively soon

fakemanoan commented 4 months ago

As DT2W has been working in recent builds, can you confirm that the feature has returned to a level at which you are happy with?

darkdragon-001 commented 4 months ago

As DT2W has been working in recent builds, can you confirm that the feature has returned to a level at which you are happy with?

Thank you so much for your work! Can I update install this version to test or do I have to reinstall all apps for this?

fakemanoan commented 4 months ago

Normal stuff applies (so 19.1 can be upgraded to the newest 19.1, not directly to 20).

Also if you download my TWRP, you can get OTAs too. Both the latest build of lineage-19.1 and TWRP can be found on my github pages, just navigate to your device.

https://fakemanoan.github.io

darkdragon-001 commented 4 months ago

The DT2W stuff is available in version 19 or 20 or both?

fakemanoan commented 4 months ago

Both 19 and 20 have DT2W

darkdragon-001 commented 4 months ago

Updated to latest 19.1 and it works! Double tap to wake anywhere and double top on top edge of the screen to lock. Thank you so much for keeping this phone alive!