faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
12.15k stars 883 forks source link

Highlighted modules on fakerjs.dev are different to README #1532

Open matthewmayer opened 1 year ago

matthewmayer commented 1 year ago

Pre-Checks

Describe the bug

From the README

From https://next.fakerjs.dev/

Seems these should be consistent? Add Names and Numbers? (And maybe Names should now be People?)

Minimal reproduction code

No response

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (8) x64 Apple M1
    Memory: 43.63 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 8.19.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 107.0.5304.87
    Firefox: 98.0
    Safari: 16.0

Which module system do you use?

Used Package Manager

npm

Shinigami92 commented 1 year ago

I will remove the bug label for now, as the WebSite has just space for 6 cards and this was an undocumented but intentional behavior. But we can rethink about it.

matthewmayer commented 1 year ago

if limited to 6 i think people/names are more important than hacker jargon

matthewmayer commented 1 year ago

are you sure its limited to 6? https://vitepress.dev/reference/default-theme-home-page#features-section says "any number of features"

Shinigami92 commented 1 year ago

I just thought so, but yes it is not hard limited, more like soft limited like we should prevent using prime numbers as these are not divisible for responsive layouts and so a card would wrap into it's own line and so on