search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
13.06k stars 920 forks source link

Credit Card number parameter #181

Open import-brain opened 2 years ago

import-brain commented 2 years ago
Screen Shot 2022-01-16 at 2 35 07 PM

In the part of the Finance section of the API docs shown above, I think it would improve the docs if we listed all possible inputs of the 'provider' parameter, such as 'Visa', 'MasterCard', etc. What would happen if someone used gibberish as a parameter there, would an error be thrown?

clarkerican commented 2 years ago

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

import-brain commented 2 years ago

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

Yes, we probably need to look at different ways to represent this, because this section taking up half of the page is not optimal.

ageddesi commented 2 years ago

What if you provide the options with an expandable section for each local?

ST-DDT commented 2 years ago

IMO we should describe a way to look these up instead.