search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
12.93k stars 919 forks source link

Check whether the system commonFileName (SK) test is still useful #1885

Closed ST-DDT closed 3 weeks ago

ST-DDT commented 1 year ago

https://github.com/faker-js/faker/blob/956a15fff5c3714485e8e612df62034a5f78c0c5/test/system.spec.ts#L429-L434

This test might have gone obsolete by updating (https://github.com/faker-js/faker/pull/808) / filtering the mime-types (https://github.com/faker-js/faker/pull/1788).

Created on behalf of @Shinigami92 in https://github.com/faker-js/faker/pull/1735#discussion_r1111216584

ST-DDT commented 1 year ago

The test now resides here:

https://github.com/faker-js/faker/blob/005369b29c7ee290a870396ff0acc85e3f715e10/test/modules/system.spec.ts#L420-L428