faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
12.56k stars 903 forks source link

Document what should appear in migration guide #2079

Closed matthewmayer closed 1 year ago

matthewmayer commented 1 year ago

Suggestion for new section to be added to CONTRIBUTING.


Documenting changes for new major versions

Each major version has an upgrading guide eg https://next.fakerjs.dev/guide/upgrading.html

While developing new features and bugfixes for the new release, changes are added to the migration guide to aid developers when the version is released.

The general principle is to document anything which requires a normal user of the library to change their code which uses Faker when upgrading to the new major version.

There are two sections

Not every change needs to be in the migration guide. If it is too long, it becomes hard for users to spot the important changes.

Should be in the guide

Doesn't need to be in the guide

matthewmayer commented 1 year ago

@faker-js/maintainers let me know if you like this in principle, if so i will add a PR which adds this to CONTRIBUTING and you can provide line-by-line feedback

matthewmayer commented 1 year ago

@faker-js/maintainers this might be nice to squeeze into 8.0.0. I feel the migration guide could be streamlined a little with some guidelines so we don't have to mention every deprecation.

Shinigami92 commented 1 year ago

@matthewmayer you missed my Discord post:

image