faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
12.98k stars 919 forks source link

Add the Yoruba Language (yo_NG) as a new locale #2341

Closed mrsimi closed 1 year ago

mrsimi commented 1 year ago

Clear and concise description of the problem

As a developer using faker I want to be able to generate fake data that are native to the Yoruba Language. This will include person names, dates, and color.

I will be willing to create a PR for it.

Suggested solution

Create a locale feature that is for the yoruba language under the yo_NG ISO

Alternative

No response

Additional context

No response

github-actions[bot] commented 1 year ago

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

matthewmayer commented 1 year ago

Are new locales expected to hit the 10 👍 threshold like feature requests? Because other recent locale additions have not had to (Serbian, Danish, Esperanto etc). My feeling is if someone is willing to put in the work to do the PR and its verifiable (e.g. not so obscure a language that it doesn't appear on Google Translate) then it shouldnt have to hit a 10 vote minimum to be merged.

ST-DDT commented 1 year ago

FFR: yo_NG the language used in Nigeria.


Feel free to create the PR. But ~one PR per module/category please e.g. person, location. (Metadata doesn't count as module/category.) Small sequential PRs are easier to review for us then large or parallel ones.

Thanks for your help.