search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.77k stars 869 forks source link

Pejorative Expression in Hungarian locale #2575

Closed dev-el-op closed 5 days ago

dev-el-op commented 4 months ago

I found a pejorative expression among the Hungarian adopted words. In line 8173 of the /src/locales/hu/word/noun.ts file, the word means btch in Hungarian. One of our testers noticed it when in a literal translation the web address of one of the example sales locations became https://unbred-btch.com/ in Hungarian.

dev-el-op commented 4 months ago

Okey, now i found like 15 of them in the same file 😅

matthewmayer commented 4 months ago

Yes these should be removed (we did this for English in https://github.com/faker-js/faker/discussions/1631 )

Would you be able to make a PR for removing any offensive vocabulary in hu locale?

dev-el-op commented 4 months ago

Absolutely, I can take care of removing any offensive vocabulary in the Hungarian locale. I'll aim to submit a pull request for this task within this week.

ST-DDT commented 4 months ago

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

import-brain commented 4 months ago

I also noticed, that the file is huge with 10620 lines. We should reduce that to 1000 entries (not sure though whether it should be in a separate PR for the pejorative expression removal).

I think separating the PRs would be better--- remove the pejorative expressions first, then reduce to 1000 entries.

matthewmayer commented 4 months ago

Might be better to reduce to 1000 first, then less hunting is required for the pejorative expressions!

ST-DDT commented 2 months ago

@dev-el-op Do you have time to create a PR that removes those expressions?

ST-DDT commented 1 month ago

@dev-el-op Any idea when you have time for this?

ST-DDT commented 2 weeks ago

I created https://github.com/faker-js/faker/pull/2816 to hopefully remove all offending words.

If there are other offending words please tell me. Otherwise we have to do that in a future PR.