faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

infra(unicorn): numeric-separators-style #2815

Open ST-DDT opened 1 month ago

ST-DDT commented 1 month ago

Ref: #2439


Enables the unicorn/numeric-separators-style lint rule.

netlify[bot] commented 1 month ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit b76648e7f19c7a1a2aea5296f8b0c2d8f404478d
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662b49bfc34f4b000880b22a
Deploy Preview https://deploy-preview-2815.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ST-DDT commented 1 month ago

Not sure about this one. Sometimes it looks useful, at other times the numbers aren't actual numbers...

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.50562% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 99.95%. Comparing base (1f7568a) to head (b76648e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2815 +/- ## ======================================== Coverage 99.95% 99.95% ======================================== Files 2973 2973 Lines 212501 212501 Branches 598 947 +349 ======================================== + Hits 212408 212413 +5 + Misses 93 88 -5 ``` | [Files](https://app.codecov.io/gh/faker-js/faker/pull/2815?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js) | Coverage Δ | | |---|---|---| | [src/modules/color/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Fcolor%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvY29sb3IvaW5kZXgudHM=) | `100.00% <100.00%> (ø)` | | | [src/modules/commerce/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Fcommerce%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvY29tbWVyY2UvaW5kZXgudHM=) | `98.57% <100.00%> (ø)` | | | [src/modules/image/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Fimage%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvaW1hZ2UvaW5kZXgudHM=) | `100.00% <100.00%> (ø)` | | | [src/modules/internet/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Finternet%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvaW50ZXJuZXQvaW5kZXgudHM=) | `100.00% <100.00%> (ø)` | | | [src/modules/location/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Flocation%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvbG9jYXRpb24vaW5kZXgudHM=) | `99.67% <100.00%> (-0.33%)` | :arrow_down: | | [src/modules/number/index.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Fnumber%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvbnVtYmVyL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | | [src/modules/internet/user-agent.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Fmodules%2Finternet%2Fuser-agent.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL21vZHVsZXMvaW50ZXJuZXQvdXNlci1hZ2VudC50cw==) | `94.11% <0.00%> (+2.05%)` | :arrow_up: | | [src/internal/mersenne.ts](https://app.codecov.io/gh/faker-js/faker/pull/2815?src=pr&el=tree&filepath=src%2Finternal%2Fmersenne.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2ludGVybmFsL21lcnNlbm5lLnRz) | `97.58% <85.00%> (ø)` | |