faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

create icon on simple-icons #2827

Open ianzone opened 4 weeks ago

ianzone commented 4 weeks ago

to create badges like vitest [![vitest](https://img.shields.io/badge/Vitest-729b1b?logo=Vitest&labelColor=grey)](https://vitest.dev/) the logo has to be available on https://wasm.simpleicons.org/?q=faker, the logo can be added to this repo https://github.com/simple-icons/simple-icons

ST-DDT commented 4 weeks ago

For what purpose do you need the logo?

ianzone commented 4 weeks ago

to add a badge to my readme file indicates i'm using fakerjs in my project.

xDivisionByZerox commented 4 weeks ago

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it :shrug:

Why would you open an issue here instead at the simple icon repo, tho? :thinking: (I have no idea how the process works)

ianzone commented 4 weeks ago

I mean, it gives for the people who use it and doesn't harm anybody who doesn't use it 🤷

I don't know if this issue can harm anybody.

Why would you open an issue here instead at the simple icon repo, tho? 🤔

I guess the author has a better idea about how the icon should look like.

(I have no idea how the process works)

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

xDivisionByZerox commented 4 weeks ago

I don't know if this issue can harm anybody.

What I wanted to say is: This "features" look very low effort/maintainable for us. So it would not hurt to give it a try.

I guess the author has a better idea about how the icon should look like.

I see (and also read it in the affiliate section in their contributions guidelines). Guess we can discuss it on this week's team meeting.

https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon

Thank you for the link. I was already reading their documentation and intended to rework my comment with a funny twist like: "(I don't know how their process works) I got it now!" I did not expect you to answer this fast :smile:

ST-DDT commented 4 weeks ago

How about this one. It is based on https://github.com/faker-js/faker/blob/next/docs/public/logo.svg

Powered by FakerJS

We might have to clean it up some more though, because at low screen sizes it gets indistinguishable.

ianzone commented 4 weeks ago

The outline is good, could you add some color to it? Otherwise, it would be very dark on a dark background.

image
ST-DDT commented 4 weeks ago

The icons have to be black and transparent. I can add a white background for better visualization on darkmode.

Powered by FakerJS

ianzone commented 4 weeks ago

looks cool

ST-DDT commented 4 weeks ago

Here a variant with only the face:

Powered by FakerJS

ST-DDT commented 4 weeks ago

IMO it is still very had to see properly when small. Maybe we have to focus just on the face and maybe fill it/invert the interior.

ST-DDT commented 4 weeks ago

Here vitest for comparison:

Powered

ianzone commented 4 weeks ago

Or just the magic hat?

ST-DDT commented 4 weeks ago

face-2

Powered by FakerJS

ST-DDT commented 4 weeks ago

Or just the magic hat?

I'll try that tomorrow.

ST-DDT commented 3 weeks ago

hat-1

Powered by FakerJS

ianzone commented 3 weeks ago
image
matthewmayer commented 3 weeks ago

I think the panda head is most visible at small sizes.

Shinigami92 commented 3 weeks ago
image

I like

image

the most

ST-DDT commented 3 weeks ago

Please don't forget that there is usually no white background:

shield-bare shield-face shield-face-filled shield-hat

ianzone commented 3 weeks ago

the icon color can be set here btw https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#7-update-the-json-data-for-simpleiconsorg

Panda head or magic hat works for me.

Shinigami92 commented 3 weeks ago

And again,

image

wins for me

I think I found my favorite and decided (for me)

ST-DDT commented 3 weeks ago

I will make some more variant soon. Especially those with filled faces with default and no rotation.

ST-DDT commented 3 weeks ago

face-3 shield-face2

Powered by FakerJS

Shinigami92 commented 3 weeks ago

face-3 shield-face2

Powered by FakerJS

dont like :(

ST-DDT commented 3 weeks ago

face-filled-2 shield-face-filled2

Powered by FakerJS

ST-DDT commented 3 weeks ago

face-filled-3 shield-face-filled3

Powered by FakerJS

ST-DDT commented 3 weeks ago

For better comparison:

Shinigami92 commented 3 weeks ago

face-filled-1 wins for me

ST-DDT commented 2 weeks ago

Team Decision

xDivisionByZerox commented 2 weeks ago

I'm "soft blocking" this issue as I'd like to talk about UI/UX related topics in our next teem meeting, next thursday.