search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

refactor(locale): activate data normalization for airline #2828

Closed xDivisionByZerox closed 4 weeks ago

xDivisionByZerox commented 4 weeks ago

Description

Follow-on to https://github.com/faker-js/faker/pull/2265

Normalize the entries in the airline module definitions in all locales.

I choose this module because all data entries are lists of objects and we did decide against object key sorting for now. That means that changes are little to none.

netlify[bot] commented 4 weeks ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit fb2201862037969db0f1800e60a9f31ff75ba531
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/661d9f1707e6dd00081367c0
Deploy Preview https://deploy-preview-2828.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.96%. Comparing base (cd5577c) to head (fb22018).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2828 +/- ## ========================================== - Coverage 99.96% 99.96% -0.01% ========================================== Files 2964 2964 Lines 212556 212541 -15 Branches 601 946 +345 ========================================== - Hits 212486 212465 -21 - Misses 70 76 +6 ``` | [Files](https://app.codecov.io/gh/faker-js/faker/pull/2828?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js) | Coverage Ξ” | | |---|---|---| | [src/locales/zh\_CN/airline/airport.ts](https://app.codecov.io/gh/faker-js/faker/pull/2828?src=pr&el=tree&filepath=src%2Flocales%2Fzh_CN%2Fairline%2Fairport.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvemhfQ04vYWlybGluZS9haXJwb3J0LnRz) | `100.00% <100.00%> (ΓΈ)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/faker-js/faker/pull/2828/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js)