search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.85k stars 877 forks source link

infra: suppress pnpm error #2835

Closed Shinigami92 closed 3 weeks ago

Shinigami92 commented 3 weeks ago

With pnpm v9 the packageManager field in package.json get checked strictly now This config suppress the error and converts it just into a warning like

[ WARN ] This project is configured to use v9.0.1 of pnpm. Your current pnpm is v9.0.4

This only affects contributors that uses pnpm natively instead of corepack

This is needed so contributors can still run preflight without having the exact pnpm bugfix version installed (like with pnpm v8 previously)

netlify[bot] commented 3 weeks ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit 45ef98eeab78f03840c1de9cc900dd85630ae134
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662227ea59a10800080a147f
Deploy Preview https://deploy-preview-2835.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (48ab524) to head (45ef98e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2835 +/- ## ========================================== - Coverage 99.95% 99.95% -0.01% ========================================== Files 2964 2964 Lines 212544 212544 Branches 945 947 +2 ========================================== - Hits 212457 212453 -4 - Misses 87 91 +4 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/faker-js/faker/pull/2835/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js)
ST-DDT commented 3 weeks ago

Please keep an eye open, to remove this property once it is no longer needed e.g. because of compatible version range checks.