Closed Shinigami92 closed 3 weeks ago
Name | Link |
---|---|
Latest commit | 9de15c8d0cf3d4ef858c227cfe0815f6011ba93d |
Latest deploy log | https://app.netlify.com/sites/fakerjs/deploys/66223779f38b3f0008398837 |
Deploy Preview | https://deploy-preview-2836.fakerjs.dev |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.95%. Comparing base (
48ab524
) to head (9de15c8
).
The referenced issue has barely any upvotes or comments. 🤔 So I consider it low prio. Also there is the current feature freezes to prepare for the v9 changes.
The other problem with putting Greek letters in fakerEL is I cannot easily use it in a helpers.fake pattern
Eg if I want "Incredible Soft Gloves are located in Section A, subsection δ" I can't do
"{{commerce.productName}} are located in Section {{foo.romanLetter}} subsection {{foo.greekLetter}}"
The other problem with putting Greek letters in fakerEL is I cannot easily use it in a helpers.fake pattern
Eg if I want "Incredible Soft Gloves are located in Section A, subsection δ" I can't do
"{{commerce.productName}} are located in Section {{foo.romanLetter}} subsection {{foo.greekLetter}}"
Can you elaborate what this has to be done with this PR? Why does it not count for chemicalElement
or airline
?
I think this might then be more a problem of fake
and is out of scope for this PR and feature implementation.
Or did I get your intend wrong? You want to use greek (mixed locale) context inside fake? This is new to me 🤔 And if so, you could still generate all this just without using fake
but just wrap in a function.
function x() {
return `${faker.commerce.productName()} are located in Section ${faker.foo.romanLetter()} subsection ${fakerEL.word.letter()}`;
~~~~~~~~~~~~~~~~~~~~~~~ this does not even exists
}
Greek/roman letters are "international"
Like even if you are writing English you might use single Greek letters for some things. Even if you are writing Chinese you might use single Roman letters for some things.
You can of course use string interpolation. But fake patterns can be used by other faker definitions so it's nice if they can access useful data.
As I don't feel healthy (again) anymore, I will close this for now
closes #558
558