faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

refactor(locale): activate data normalization for color #2837

Closed xDivisionByZerox closed 3 weeks ago

xDivisionByZerox commented 3 weeks ago

Description

Follow-on to https://github.com/faker-js/faker/pull/2265

Normalize the entries in the color module definitions in all locales.

I choose this module because only one file per locale. This should make reviews more trivial.

netlify[bot] commented 3 weeks ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit 416e89e63b334336ef64d50e40696c788ff0f531
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662560d3ce8d890008e43a5c
Deploy Preview https://deploy-preview-2837.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (81d0718) to head (416e89e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2837 +/- ## ========================================== - Coverage 99.96% 99.95% -0.01% ========================================== Files 2973 2973 Lines 212613 212613 Branches 948 602 -346 ========================================== - Hits 212528 212526 -2 - Misses 85 87 +2 ``` | [Files](https://app.codecov.io/gh/faker-js/faker/pull/2837?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js) | Coverage Δ | | |---|---|---| | [src/locales/ar/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Far%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvYXIvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/az/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Faz%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvYXovY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/base/color/space.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fbase%2Fcolor%2Fspace.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvYmFzZS9jb2xvci9zcGFjZS50cw==) | `100.00% <100.00%> (ø)` | | | [src/locales/dv/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fdv%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZHYvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/el/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fel%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZWwvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/en/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fen%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZW4vY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/es/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fes%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZXMvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/es\_MX/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Fes_MX%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZXNfTVgvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/fa/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Ffa%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZmEvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/fr/color/human.ts](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree&filepath=src%2Flocales%2Ffr%2Fcolor%2Fhuman.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZnIvY29sb3IvaHVtYW4udHM=) | `100.00% <100.00%> (ø)` | | | ... and [16 more](https://app.codecov.io/gh/faker-js/faker/pull/2837?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/faker-js/faker/pull/2837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js)