faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

docs: link to the latest release of the current version #2856

Closed ST-DDT closed 2 weeks ago

ST-DDT commented 2 weeks ago

Fixes #2850 (part2)

This change can be tested by:

export BRANCH=v9
pnpm run docs:dev
export BRANCH=next
pnpm run docs:dev
export BRANCH=other
pnpm run docs:dev

v9 grafik

next grafik

other grafik

netlify[bot] commented 2 weeks ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit bb8878c58960c0b3c1933d2a749382939952af2f
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66308a93fc083600088b70e7
Deploy Preview https://deploy-preview-2856.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (b87acb8) to head (83228b3).

:exclamation: Current head 83228b3 differs from pull request most recent head bb8878c. Consider uploading reports for the commit bb8878c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2856 +/- ## ========================================== - Coverage 99.96% 99.95% -0.01% ========================================== Files 2975 2973 -2 Lines 214451 212501 -1950 Branches 952 601 -351 ========================================== - Hits 214378 212415 -1963 - Misses 73 86 +13 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/faker-js/faker/pull/2856/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js)
xDivisionByZerox commented 2 weeks ago

As general feedback: If providing screenshots, adding a "before" and "after" image is generally a good idea. If you don't want to do this, at least explain what this image shows that is different from the current behavior. I had difficulties understanding what this PR changed even with the provided title, description, and pictures. In fact, the images made it more confusing for me when I started looking at it.

ST-DDT commented 2 weeks ago

If providing screenshots, adding a "before" and "after" image is generally a good idea.

Thanks, I try to keep it in mind.