Closed ST-DDT closed 2 weeks ago
Name | Link |
---|---|
Latest commit | bb8878c58960c0b3c1933d2a749382939952af2f |
Latest deploy log | https://app.netlify.com/sites/fakerjs/deploys/66308a93fc083600088b70e7 |
Deploy Preview | https://deploy-preview-2856.fakerjs.dev |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.95%. Comparing base (
b87acb8
) to head (83228b3
).:exclamation: Current head 83228b3 differs from pull request most recent head bb8878c. Consider uploading reports for the commit bb8878c to get more accurate results
As general feedback: If providing screenshots, adding a "before" and "after" image is generally a good idea. If you don't want to do this, at least explain what this image shows that is different from the current behavior. I had difficulties understanding what this PR changed even with the provided title, description, and pictures. In fact, the images made it more confusing for me when I started looking at it.
If providing screenshots, adding a "before" and "after" image is generally a good idea.
Thanks, I try to keep it in mind.
Fixes #2850 (part2)
2850
This change can be tested by:
v9
next
other