search

faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
11.86k stars 877 forks source link

refactor(locale): normalize music data #2857

Closed xDivisionByZerox closed 2 weeks ago

xDivisionByZerox commented 2 weeks ago

Description

Follow-on to https://github.com/faker-js/faker/pull/2265

Normalize the entries in the music module definitions in all locales.

I choose this module as locale data are still limited. additionally, no data set exceedes the 1k entry limit, so all locale file changes are based on entry sorting.

netlify[bot] commented 2 weeks ago

Deploy Preview for fakerjs ready!

Name Link
Latest commit de6cd7a9f6c0859c1c142c6b04534f284d71a833
Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662f4b18e3a4510008c526c8
Deploy Preview https://deploy-preview-2857.fakerjs.dev
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (next@1a21296). Click here to learn what that means.

:exclamation: Current head 55f0d56 differs from pull request most recent head de6cd7a. Consider uploading reports for the commit de6cd7a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2857 +/- ## ======================================= Coverage ? 99.96% ======================================= Files ? 2973 Lines ? 212501 Branches ? 597 ======================================= Hits ? 212422 Misses ? 79 Partials ? 0 ``` | [Files](https://app.codecov.io/gh/faker-js/faker/pull/2857?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js) | Coverage Δ | | |---|---|---| | [src/locales/en/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fen%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZW4vbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/en/music/song\_name.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fen%2Fmusic%2Fsong_name.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZW4vbXVzaWMvc29uZ19uYW1lLnRz) | `100.00% <100.00%> (ø)` | | | [src/locales/fa/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Ffa%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZmEvbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/fr/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Ffr%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvZnIvbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/he/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fhe%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvaGUvbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/ur/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fur%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvdXIvbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/zh\_CN/music/genre.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fzh_CN%2Fmusic%2Fgenre.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvemhfQ04vbXVzaWMvZ2VucmUudHM=) | `100.00% <100.00%> (ø)` | | | [src/locales/zh\_CN/music/song\_name.ts](https://app.codecov.io/gh/faker-js/faker/pull/2857?src=pr&el=tree&filepath=src%2Flocales%2Fzh_CN%2Fmusic%2Fsong_name.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=faker-js#diff-c3JjL2xvY2FsZXMvemhfQ04vbXVzaWMvc29uZ19uYW1lLnRz) | `100.00% <100.00%> (ø)` | |