Open matthewmayer opened 2 months ago
Thank you for your feature proposal.
We marked it as "waiting for user interest" for now to gather some feedback from our community:
If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.
We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.
We will start the implementation based on:
the number of votes (:+1:) and comments
the relevance for the ecosystem
availability of alternatives and workarounds
and the complexity of the requested feature
We do this because:
There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
Every feature we add to faker has "costs" associated to it:
Do you want exactly those well known planet names or any planet names?
Do you want exactly those well known planet names or any planet names?
This was exactly my first thought. Even if we dont want scientific planets now, we might want to consider a method name that does not get in conflict if we want to generate names like KMT-2021-BLG-1150L b
Just the major planets
Pluto is not a planet 😀
For comparison Faker-Ruby has a few space methods. Their "planet" method is "planet (in our solar System)" https://github.com/faker-ruby/faker/blob/main/doc/default/space.md
Currently, I think space is the best match, followed by location and then science. From science.planet I would except the numbered planet notation.
Currently, I think space is the best match, followed by location and then science. From science.planet I would except the numbered planet notation.
I understand your reasoning, but I'm not a big fan of introducing new modules at the current moment. We still have some places where we are not sure whether a function would be better located in module X or Y. Adding more modules makes this problem potentially worse until we have clear definitions about the "Module" term, or we introduce an easy way to reference aliases.
That being said, I would not expect planet
to be located under the LocationModule as this has more of an "on earth locations"-vibe to me.
Science sounds reasonable to me. But again, @ST-DDT made a good point with the "numbered planet notations".
Another thing I want to point out is the method faker.person.zodiacSign
. While not directly related, they could end out being on the same meta level. I just want this to be considered. Not putting "planet" into the PersonModule, but the fact of potential relation in general.
Nothing we have to decide now, lets wait on more input/upvotes.
Clear and concise description of the problem
As a developer using faker i want to generate planet names.
Suggested solution
Implement
faker.science.planet()
with the following data in EnglishAlternative
faker.location.planet()
?Additional context
No response