faker-js / faker

Generate massive amounts of fake data in the browser and node.js
https://fakerjs.dev
Other
13.08k stars 924 forks source link

`faker.time` module to simplify time (not datetime) usecases #3107

Open douglasg14b opened 2 months ago

douglasg14b commented 2 months ago

Clear and concise description of the problem

Generating fakes specifically for times, not necessarily dates. These will only produce times, and not consider dates.

The date fucntions do perform this utility to some degree but require additional work to achieve which could be baked into a time module directly.

Suggested solution

in module faker.date or in a new module faker.time it would have fucntions for:

These should accept a format argument that allows the time output to be formatted as 24/12h time (or others)

Alternative

Users build their own time fucntions that work on top of faker.date

Additional context

Naive examples from my own use:

function getFakeTime(options?: { from?: Date; to?: Date } = {}) {
    const from = options?.from || '2024-01-01T00:00:00.000Z';
    const to = options?.to || '2024-01-01T23:59:59.999Z';

    return faker.date.between({from, to});
}

function getFake24hTime(time?: Date) {
    const dateTime = time || getFakeTime();
    return dateTime.toISOString().slice(11, 16);
}

function getFake24hTimeRange() {
    const from = getFakeTime();
    const to = getFakeTime({from});
    return {
        from: getFake24hTime(from),
        to: getFake24hTime(to),
    }
}
github-actions[bot] commented 2 months ago

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

ST-DDT commented 2 months ago

The date functions do perform this utility to some degree but require additional work to achieve which could be baked into a time module directly.

Could you explain which issues you are encountering with the date module when generating times other than date.toISOString().slice(11, 16)?

Maybe these issues also apply to the date module in general and just haven't been raised yet.


  • faker.time.range
return {
        from: getFake24hTime(from),
        to: getFake24hTime(to),
    }

IMO it is unlikely that we add a method like this, because it is likely a user dependent structure. e.g. maybe you use {from,to}, others might want to use {start,end} or from-to.

As a workaround for that, I can recommend the faker.date.betweens({ from, to, count: 2) function (or from the time module, if we add it). It returns a sorted list, so you can just use it like this:

const [ rangeFrom, rangeTo ] = faker.date.betweens({ from, to, count: 2);
return {
    from: toTime(rangeFrom),
    to: toTime(rangeTo ),
}

These should accept a format argument that allows the time output to be formatted as 24/12h time (or others)

IMO the format parameter is unlikely, because there are too many possible variations to it, that we might end up with a full date formatting library.

e.g. one user wants the time formatted like this: HH:mm, HH:mm:ss, or HH:mm:ss.SSS, what about timezones, 12h vs 24h format?

This is currently my main concern with the time module.

ST-DDT commented 1 month ago

@douglasg14b Could you please answer these questions/respond to the suggestions?

Or are the additions to the following section sufficient?

douglasg14b commented 1 month ago

Hi, sorry, my github notifications as skuffed (nearly 1000/d for work, and when not SSOd like when home github shows me zero other notifications for some reason). If I am mentioned I get a push notification though.


That said:, the issue I was encountering was:

  1. Generating times on the same day
  2. Generated formatted times as strings

I think these are two different problems.

  1. Could be solved as part of the date module
  2. Could be soled by utilizing a formatting lib (ie. dayjs which is minuscule) with a date argument or helper
ST-DDT commented 1 month ago

@douglasg14b

Generating times on the same day

Would the following solve your issue:

const someDate = new Date(faker.date.soon().toISOString().substring(0, 10)).valueOf();
const timeAtThatDay = faker.date.between({from: someDate, to: someDate + 86400000 - 1000});

The main issue we have here is that the it is unclear, which timezone the time (of day) should be in. The example assumes local timezone.

I assume some usecases apply to subsets of days. e.g. working hours.

const timeAtThatWorkDay = faker.date.between({from: someDate + 9 * 60 * 60 * 1000, to: someDate + 17 * 60 * 60 * 1000});

But what if you want the times to be alligned in a 15minute grid?

Maybe a custom/user defined function can produce these results more easily?

const slottedTimeAtThatWorkDay = new Date(someDate + 9 * 60 * 60 * 1000 + faker.number.int({multipleOf: 15, min: 0, max: 8 * 60}) * 60 * 1000)

I could see usefulness for multipleOf/a slotting feature for between/the date module in general though.

Is any of this what you need? Any ideas on how to solve the timezone issue?


Generated formatted times as strings

IMO that is out of scope for faker