[Actions] TruffleRuby checks fails silently - Githubissues

faker-ruby / faker

A library for generating fake data such as names, addresses, and phone numbers.

MIT License

11.26k stars 3.18k forks source link

[Actions] TruffleRuby checks fails silently #2309

Closed meuble closed 2 years ago

meuble commented 3 years ago

Description

TruffleRuby fails to run the tests without errors, but this doesn't prevent the CI to raise any warning.

To Reproduce

Run the tests on TruffleRuby.

Expected behavior

I would expect that if some of the tests doesn't succeed, the CI should prevent the PR to be accepted and should display warnings.

I would also expect the tests to fully succeed and TruffelRuby.

Additional context

See the following PR for example (one accepted, on pending — currently at least):

sudeeptarlekar commented 2 years ago

Found something happening differently in truffleruby for source method. Created issue for same. https://github.com/oracle/truffleruby/issues/2569

Meanwhile adding quick patch for same and raising a PR.