Closed chamini2 closed 11 months ago
Will a person be able to use fal-serverless (new fal) and dbt-fal? I see that we're putting the fal cli in fal namespace, so just curious if the CLI and serverless functions can work together in the same environment.
Even though fal cli is in the fal namespace, notice that the whole project is in src/fal/dbt/*
. That means that to import anything from it you use import fal.dbt
.
This is the same behavior we see for dbt adapters. They install modules in the dbt namespace, but inside the dbt.adapters.<adapter-name>
module, so it does not conflict with imports from dbt-core .
Let me know if I did not explain myself well and I can clarify!
Some tests are set to @todo, does this mean that this feature doesn't work for those databases for both CLI and adapter?
The tests right now keep being separate, we test the cli and adapter separately.
So a todo in the cli_tests folder applies to cli and a todo in the integration_tests folder applies to adapter.
🚢 thank you @chamini2
The idea of this PR is to merge the 2 packages into one, and we would start releasing only the dbt-fal package.
New
dbt-fal
command line toolWe now install the fal and dbt-fal CLIs, they are the same but the
fal
one gets a warning when started.Warning on fal imports
Another thing to consider is that now imports from
fal
moved tofal.dbt
. Now we get warnings forfal
direct imports.To later free the fal namespace.
Run tests for:
Closes FEA-1227 Closes FEA-1263 Closes FEA-1267