search

fal-ai / fal

⚡ Fastest way to serve open source ML models to millions
https://fal.ai/docs
Apache License 2.0
549 stars 47 forks source link

refactor: move env var to ignore fal keys to flags.py #153

Closed chamini2 closed 7 months ago

efiop commented 7 months ago

Looks like mypy is not happy about mainify. Unrelated to this PR, I'll take a look on top.

chamini2 commented 7 months ago

oook, now I see why we did not do this before. We mainify this function and run it in the remote env, so we must run os.environ check separately and not use any fal deps inside of it

efiop commented 7 months ago

Hm, tests are failing - might be that the module triggered a need to do mainify here too, I'll need to check. I guess another reason to hurry up with cloudpickle. https://github.com/fal-ai/fal/issues/142