fix(api): use same logger for LocalHost

fal-ai / fal

⚡ Fastest way to serve open source ML models to millions

https://fal.ai/docs

Apache License 2.0

509 stars 44 forks source link

fix(api): use same logger for LocalHost #154

Closed efiop closed 5 months ago

efiop commented 5 months ago

Provides consistent output between remote and local hosts.

Before:

After:

which is consistent with remote.

Pre-requisite for next steps in cli's ux.

linear[bot] commented 5 months ago

FEA-2224 improve remote log printing in fal cli

isidentical commented 5 months ago

thanks! by the way, a general fyi, no one really uses the local mode so if at any point it becomes cumbersome to support, we can drop it completely.

efiop commented 5 months ago

@isidentical Thanks! I did hear that people use it for testing (me included), but yeah, if it becomes a big pain in the butt - I agree that we could obviously drop it. For me it is a chance to dig deeper in fal and isolate, so I'm just fixing these lowhangers along the way for consistency and testing purposes.

isidentical commented 5 months ago

I did hear that people use it for testing (me included),

the only reason why i have ever used this was to onboard people to run stuff locally. but yeah, other than that this is not super useful.