search

falconindy / ponymix

CLI volume control for PulseAudio
MIT License
179 stars 27 forks source link

increase VALUE fails to cap at 100 #13

Closed holomorph closed 11 years ago

holomorph commented 11 years ago 
[~]$ ponymix get-volume 
100
[~]$ ponymix increase 1
101
falconindy commented 11 years ago

Intentional. If you read the code, volume is capped at 150. On Jan 19, 2013 11:58 PM, "holomorph" notifications@github.com wrote:

[~]$ ponymix get-volume 100 [~]$ ponymix increase 1 101

— Reply to this email directly or view it on GitHubhttps://github.com/falconindy/ponymix/issues/13.

holomorph commented 11 years ago

The manual didn't reflect this change for increase. I knew you could set-volume over 100 as it's characteristic of pulse, but using increase would still cap at 100. As exceeding 100 can result in clipping, this was good functionality.

falconindy commented 11 years ago

Fair enough, and easy to fix:

2bdbd84cc41975c7