search

falconindy / ponymix

CLI volume control for PulseAudio
MIT License
177 stars 27 forks source link

Resolve devices by name only: #31 #32

Open SuperFluffy opened 9 years ago

SuperFluffy commented 9 years ago

This patch addresses issue #31 :

ponymix now resolves devices using only the name of the devices specified. The --source and --sink keywords are silently ignored. On the other hand, if no device is explicitly requested, the keywords will result in the name of the respective default device being queried. Actions are then taken based on the resulting name only.

Note: targetting the monitor of a device by supplying it with the complement keyword is no longer possible. For example:

% ponymix --source -d alsa_output.pci-0000_00_1b.0.analog-stereo

This used to target the source of the output device, which in this case has the full name alsa_output.pci-0000_00_1b.0.analog-stereo.monitor. Maybe we could introduce a --monitor flag?

SuperFluffy commented 9 years ago

Removed the function and cleaned up my code some.

falconindy commented 9 years ago

Looks good. Could you rebase and squash into a single commit?