search

falconre / falcon

Binary Analysis Framework in Rust
Apache License 2.0
549 stars 47 forks source link

Updating dependencies and fixing linting #78

Closed srikwit closed 4 years ago

srikwit commented 4 years ago

I've used "*" so that the project can be maintained against the latest libraries. I have tested it to be working on nightly build without any issues.

Additionally, I have used cargo clippy and cargo fix to fix linting issues.

endeav0r commented 4 years ago

The cargo clippy and cargo fix I will take, but I don't want to match all the dependencies against "*". I'd like to leave things specified out to at least the minor version.

If you want/need to bump the versions, that's fine we can do that, but I'm not comfortable right now with "*".

srikwit commented 4 years ago

I agree, I can maintain this in my personal branch with the "*" packages. Thanks for accepting the pull request.