search

falconre / falcon

Binary Analysis Framework in Rust
Apache License 2.0
551 stars 45 forks source link

De-linting #85

Closed oblivia-simplex closed 4 years ago

oblivia-simplex commented 4 years ago

Did a fair bit of de-linting, so that the project now passes cargo clippy --all.

emmanuel099 commented 4 years ago

Thanks for your PR!

Most of your PR looks good already. Can you please fix the compilation errors? See https://travis-ci.org/github/falconre/falcon/builds/702122692

oblivia-simplex commented 4 years ago

Ah, that must be the result of me listening to clippy and deleting a bunch of "unnecessary" into()s! I didn't see these errors when building with the capstone4 feature enabled, so I guess they must be capstone3 specific. I'm unfortunately unable to compile the capstone3 version on my system, as it stands, but I could try to set up a VM or docker container to do so.

On Sat, Jun 27, 2020 at 7:29 AM Emmanuel Pescosta notifications@github.com wrote:

Thanks for your PR!

Most of your PR looks good already. Can you please fix the compilation errors? See https://travis-ci.org/github/falconre/falcon/builds/702122692

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/falconre/falcon/pull/85#issuecomment-650538894, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBDP65S6W5R5YTIKWUSTWLRYXCXZANCNFSM4OITDGUQ .

endeav0r commented 4 years ago

It may be time to drop capstone 3 support...

oblivia-simplex commented 4 years ago

Have you thought of switching over to the capstone crate? Or are there features in falcon_capstone that aren't replicated there?

On Sat, Jun 27, 2020 at 1:15 PM Alex Eubanks notifications@github.com wrote:

It may be time to drop capstone 3 support...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/falconre/falcon/pull/85#issuecomment-650580781, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBDP6ZFH3BXEVFHHSOKOLTRYYLJFANCNFSM4OITDGUQ .

endeav0r commented 4 years ago

If you’re talking about the crate where m4b is a maintainer, that crate postdates Falcon. We could switch, and I’m not against it, but it would take a lot of work and modifications to the lifters.

endeav0r commented 4 years ago

I haven't forgotten this. My plan is to merge this over the weekend, break the build, and then fix it.